Skip to content

Print full_name after precompiling extension#60456

Merged
IanButterworth merged 3 commits intoJuliaLang:masterfrom
JoshuaLampert:print-full_name-precompile-extension
Dec 23, 2025
Merged

Print full_name after precompiling extension#60456
IanButterworth merged 3 commits intoJuliaLang:masterfrom
JoshuaLampert:print-full_name-precompile-extension

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Contributor

@JoshuaLampert JoshuaLampert commented Dec 23, 2025 •
edited by IanButterworth
Loading

This PR fixes #60047 to print the full package name ParentPkg → ExtensionName instead of only the ExtensionName to match what the docs say:

In Pkg output, extension names are always shown together with their parent package name.

I have looked for more possible locations, which should print the full_name and found the possible candidates:

julia/base/precompilation.jl

Line 936 in db0ee41

println(io, pkg.name, color_string(str, Base.warn_color()))

julia/base/precompilation.jl

Line 1329 in db0ee41

print(err_str, "\n", dep.name, " ")

julia/base/precompilation.jl

Line 1380 in db0ee41

println(io, " ", pkg.name, _color_string(" Being precompiled by $(pkgspidlocked[pkg_config])", Base.info_color(), hascolor))

For these locations, I'm not entirely sure though whether they should print the full name.

Since this is my first PR to julia itself, I would be grateful for any guidance on anything I might have missed.

Fixes #60047

@IanButterworth
Copy link
Copy Markdown
Member

IanButterworth commented Dec 23, 2025

This looks correct and all the places you highlighted also. If you can add them I'll approve. Thanks!

@JoshuaLampert
Copy link
Copy Markdown
Contributor Author

JoshuaLampert commented Dec 23, 2025

Great, I'll add them in a minute. Thanks for the quick reply!

@JoshuaLampert
Copy link
Copy Markdown
Contributor Author

JoshuaLampert commented Dec 23, 2025 •
edited
Loading

I added the first two. For the third one within precompile_pkgs_maybe_cachefile_lock, we do not have access to ext_to_parent though. Should we additionally pass ext_to_parent to precompile_pkgs_maybe_cachefile_lock?

@IanButterworth
Copy link
Copy Markdown
Member

IanButterworth commented Dec 23, 2025

I think so, or pass in the result of full_name as a string?

@JoshuaLampert
Copy link
Copy Markdown
Contributor Author

JoshuaLampert commented Dec 23, 2025

I think so, or pass in the result of full_name as a string?

I did that in 7c59dfb.

@lgoettgens
Copy link
Copy Markdown
Contributor

lgoettgens commented Dec 23, 2025

Thanks, this really bothered me a few times lately. It would be great if this could get backported to 1.12 and 1.13.

@IanButterworth IanButterworth added backport 1.10 Change should be backported to the 1.10 release backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Dec 23, 2025
@IanButterworth IanButterworth merged commit 3690b1e into JuliaLang:master Dec 23, 2025
12 checks passed
@IanButterworth
Copy link
Copy Markdown
Member

IanButterworth commented Dec 23, 2025

Thanks!

@JoshuaLampert JoshuaLampert deleted the print-full_name-precompile-extension branch December 23, 2025 22:14
This was referenced Jan 9, 2026
Merged
Merged
DilumAluthge added a commit that referenced this pull request Jan 16, 2026
@DilumAluthge
Print full_name after precompiling extension (#60456)
6f29f9b 
(cherry picked from commit 3690b1e)

Note: This cherry-pick required manual conflict-resolution.
@JoshuaLampert JoshuaLampert mentioned this pull request Jan 19, 2026
Draft
DilumAluthge added a commit that referenced this pull request Jan 19, 2026
@DilumAluthge
Print full_name after precompiling extension (#60456)
a7ec7a2 
(cherry picked from commit 3690b1e)

Note: This cherry-pick required manual conflict-resolution.
@DilumAluthge DilumAluthge mentioned this pull request Jan 19, 2026
Merged
71 tasks
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Feb 3, 2026
@KristofferC KristofferC mentioned this pull request Feb 4, 2026
Merged
56 tasks
@KristofferC KristofferC mentioned this pull request Feb 20, 2026
Merged
45 tasks
@KristofferC KristofferC mentioned this pull request Mar 13, 2026
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IanButterworth IanButterworth IanButterworth approved these changes

Assignees

@vtjnash vtjnash

Labels

backport 1.10 Change should be backported to the 1.10 release backport 1.13 Change should be backported to release-1.13 package extensions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parent name of extension not shown in precompilation finished message

6 participants

@JoshuaLampert @IanButterworth @lgoettgens @vtjnash @KristofferC @LilithHafner